bitkeeper revision 1.1159.1.236 (416fe93f1eolBWPXpS5xz_W7C8c-oQ)
authorkaf24@freefall.cl.cam.ac.uk <kaf24@freefall.cl.cam.ac.uk>
Fri, 15 Oct 2004 15:14:07 +0000 (15:14 +0000)
committerkaf24@freefall.cl.cam.ac.uk <kaf24@freefall.cl.cam.ac.uk>
Fri, 15 Oct 2004 15:14:07 +0000 (15:14 +0000)
In-comment questions have been answered.

xen/arch/x86/shadow.c

index b08295ce067606f0cc9cacf363e2525d2a80e071..bd9a796db398c15daa2f88182b0d2d8fa0a172ce 100644 (file)
@@ -256,7 +256,6 @@ static int shadow_mode_table_op(
 
     switch ( op )
     {
-        /* XXX KAF: Do we really need this function? Is it any use? */
     case DOM0_SHADOW_CONTROL_OP_FLUSH:
         free_shadow_state(m);
 
@@ -268,11 +267,6 @@ static int shadow_mode_table_op(
         break;
    
     case DOM0_SHADOW_CONTROL_OP_CLEAN:
-        /*
-         * XXX KAF: Why not just free_shadow_state()? Is zeroing L2's faster?
-         * If so, why wouldn't zeroing L1's be better than freeing them, as we
-         * do now?
-         */
         clear_shadow_state(m);
 
         sc->stats.fault_count       = m->shadow_fault_count;